Estate style cleanup: keep client BugSink DSN, split Main HUD chrome #1

Merged

epistemophiliac merged 2 commits from style/estate-cleanup into main 2026-07-27 06:07:11 +00:00

Conversation 0 Commits 2 Files changed 12 +571 -490

epistemophiliac commented 2026-07-27 06:03:06 +00:00

Owner

Copy link

Summary

• Keep the BugSink client ingest DSN in the APK (required so every player's device can report); document that it is public ingest, not an admin secret. Rename script to BugSinkClient.gd because Godot forbids class_name matching the BugSink autoload.
• Split HUD build/layout into HudChrome.gd; Main stays the run/tutorial controller (class_name AphelionMain). Document signals; tighten a few typed containers.
• Add scripts/ci_shellcheck.sh + Jenkins Shellcheck stage (Estate Bash gate).

Test plan

• bash scripts/ci_shellcheck.sh
• bash scripts/ci_test.sh — 170/170 passed
• Jenkins green on the PR branch
• Smoke: title → Options → Back; Begin Run → layout on phone-ish viewport

## Summary - Keep the BugSink **client ingest DSN** in the APK (required so every player's device can report); document that it is public ingest, not an admin secret. Rename script to `BugSinkClient.gd` because Godot forbids `class_name` matching the `BugSink` autoload. - Split HUD build/layout into `HudChrome.gd`; Main stays the run/tutorial controller (`class_name AphelionMain`). Document signals; tighten a few typed containers. - Add `scripts/ci_shellcheck.sh` + Jenkins `Shellcheck` stage (Estate Bash gate). ## Test plan - [x] `bash scripts/ci_shellcheck.sh` - [x] `bash scripts/ci_test.sh` — 170/170 passed - [ ] Jenkins green on the PR branch - [ ] Smoke: title → Options → Back; Begin Run → layout on phone-ish viewport

epistemophiliac added 1 commit 2026-07-27 06:03:07 +00:00

Align Aphelion with Estate style gates without ripping out client BugSink DSN. ... 6cd0934ce4

Keep the public ingest DSN in-client (required for every player's reports), document why class_name is BugSinkClient vs autoload BugSink, split HUD chrome out of Main, document signals, tighten a few typed containers, and add a shellcheck CI stage.

Co-authored-by: Cursor <[email protected]>

epistemophiliac added 1 commit 2026-07-27 06:07:08 +00:00

v0.10.6: estate style cleanup — HudChrome split, shellcheck gate, BugSink docs ... 42774a0bba

Co-authored-by: Cursor <[email protected]>

epistemophiliac merged commit cd7f9168ad into main 2026-07-27 06:07:11 +00:00

epistemophiliac deleted branch style/estate-cleanup 2026-07-27 06:07:11 +00:00

epistemophiliac referenced this pull request from a commit 2026-07-27 06:07:12 +00:00

Merge pull request 'Estate style cleanup: keep client BugSink DSN, split Main HUD chrome' (#1) from style/estate-cleanup into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

epistemophiliac/gametestv1!1

No description provided.