From fcfe63e0dfa7743a1d8e5d0008065de5d2c434c1 Mon Sep 17 00:00:00 2001 From: kelvine Date: Mon, 27 Jan 2025 07:43:47 +0200 Subject: [PATCH] Update custom-apps.md (#1554) * Update custom-apps.md grammar fixes * Remove redis-cache volume (#1555) * Remove redis-cache volume * remove from docs * ci: fix pre-commit --------- Co-authored-by: Revant Nandgaonkar --------- Co-authored-by: Salah Aldin Fateh <83924106+sdfateh@users.noreply.github.com> Co-authored-by: Revant Nandgaonkar --- docs/custom-apps.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/custom-apps.md b/docs/custom-apps.md index d979aa5d..9d5acaeb 100644 --- a/docs/custom-apps.md +++ b/docs/custom-apps.md @@ -2,7 +2,7 @@ Base64 encoded string of `apps.json` file needs to be passed in as build arg environment variable. -Create following `apps.json` file: +Create the following `apps.json` file: ```json [ @@ -23,7 +23,7 @@ Create following `apps.json` file: Note: -- `url` needs to be http(s) git url with personal access tokens without username eg:- `http://{{PAT}}@github.com/project/repository.git` in case of private repo. +- The `url` needs to be http(s) git url with personal access tokens without username eg:- `http://{{PAT}}@github.com/project/repository.git` in case of private repo. - Add dependencies manually in `apps.json` e.g. add `erpnext` if you are installing `hrms`. - Use fork repo or branch for ERPNext in case you need to use your fork or test a PR. @@ -139,7 +139,7 @@ The environment variables can be set in the shell or in the .env file as [setup- - `HTTP_PUBLISH_PORT`: The port to publish through no SSL channel. Default depending on deployment, it may be `80` if SSL activated or `8080` if not. - `HTTPS_PUBLISH_PORT`: The secure port to publish using SSL. Default is `443`. -Make sure image name is correct to be pushed to registry. After the images are pushed, you can pull them to servers to be deployed. If the registry is private, additional auth is needed. +Make sure the image name is correct before pushing to the registry. After the images are pushed, you can pull them to servers to be deployed. If the registry is private, additional auth is needed. #### Example