From ef6963aa369fa9a0b1eab630e920c5e930465aca Mon Sep 17 00:00:00 2001
From: Lev <mail@vrslev.com>
Date: Mon, 8 Nov 2021 17:50:33 +0300
Subject: [PATCH] refactor(erpnext-nginx): Dockerfile

---
 build/erpnext-nginx/Dockerfile | 26 ++++++++++++++++----------
 1 file changed, 16 insertions(+), 10 deletions(-)

diff --git a/build/erpnext-nginx/Dockerfile b/build/erpnext-nginx/Dockerfile
index 0f6a7586..de0fde1c 100644
--- a/build/erpnext-nginx/Dockerfile
+++ b/build/erpnext-nginx/Dockerfile
@@ -2,25 +2,31 @@ ARG NODE_IMAGE_TAG=14-bullseye-slim
 ARG DOCKER_REGISTRY_PREFIX=frappe
 ARG IMAGE_TAG=develop
 
-FROM node:${NODE_IMAGE_TAG}
+FROM node:${NODE_IMAGE_TAG} as builder
 
 ARG GIT_REPO=https://github.com/frappe/erpnext
 ARG GIT_BRANCH=develop
+
 ARG FRAPPE_BRANCH=${GIT_BRANCH}
 
-COPY build/erpnext-nginx/install_app.sh /install_app
-RUN chmod +x /install_app && \
-  apt-get update -y && \
-  apt-get install build-essential git python2 -y && \
-  apt-get clean && \
-  rm -rf /var/lib/apt/lists/*
+RUN apt-get update \
+    && apt-get install --no-install-recommends -y \
+    wget \
+    python2 \
+    git \
+    build-essential \
+    && rm -rf /var/lib/apt/lists/*
+
+COPY build/erpnext-nginx/install_app.sh /install_app
+RUN chmod +x /install_app \
+    && /install_app erpnext ${GIT_REPO} ${GIT_BRANCH} ${FRAPPE_BRANCH}
 
-RUN /install_app erpnext ${GIT_REPO} ${GIT_BRANCH} ${FRAPPE_BRANCH}
 
 FROM ${DOCKER_REGISTRY_PREFIX}/frappe-nginx:${IMAGE_TAG}
 
-COPY --from=0 /home/frappe/frappe-bench/sites/ /var/www/html/
-COPY --from=0 /rsync /rsync
+COPY --from=builder /home/frappe/frappe-bench/sites/ /var/www/html/
+COPY --from=builder /rsync /rsync
+
 RUN echo "erpnext" >> /var/www/html/apps.txt
 
 VOLUME [ "/assets" ]