From 87895a7049de4dda6dc3efc534c6ea78d347f365 Mon Sep 17 00:00:00 2001 From: Malay Gondalia <134581231+malay-gondalia@users.noreply.github.com> Date: Thu, 29 Feb 2024 20:46:03 +0530 Subject: [PATCH] Update custom-apps.md made document clear to insert custom app to build and resolved error - "url": "https://user:password@git.example.com/project/repository.git", to "url": "https://{{ PAT }}@git.example.com/project/repository.git", --- docs/custom-apps.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/docs/custom-apps.md b/docs/custom-apps.md index c2cb6f85..6c6b6c29 100644 --- a/docs/custom-apps.md +++ b/docs/custom-apps.md @@ -10,6 +10,9 @@ cd frappe_docker `apps.json` needs to be passed in as build arg environment variable. ```shell + +set env variable APPS_JSON using following shell command + export APPS_JSON='[ { "url": "https://github.com/frappe/erpnext", @@ -20,10 +23,13 @@ export APPS_JSON='[ "branch": "version-15" }, { - "url": "https://user:password@git.example.com/project/repository.git", + "url": "https://{{ PAT }}@git.example.com/project/repository.git", "branch": "main" } ]' + +set env variable APPS_JSON_BASE64 using following shell command + export APPS_JSON_BASE64=$(echo ${APPS_JSON} | base64 -w 0) ``` @@ -35,7 +41,7 @@ export APPS_JSON_BASE64=$(base64 -w 0 /path/to/apps.json) Note: -- `url` needs to be http(s) git url with token/auth in case of private repo. +- `url` needs to be http(s) git url with personal access tokens without username eg:- http://{{PAT}}@github.com/project/repository.git in case of private repo. - add dependencies manually in `apps.json` e.g. add `payments` if you are installing `erpnext` - use fork repo or branch for ERPNext in case you need to use your fork or test a PR.