From 5275cb86951522dd8bff0cdaeecc193d3538c927 Mon Sep 17 00:00:00 2001
From: Digikwal <79085106+digikwal@users.noreply.github.com>
Date: Tue, 24 Jun 2025 18:48:32 +0200
Subject: [PATCH] chore(stack): fix shellcheck warnings for safe argument
 handling

In stack.sh line 9:
ARGS="$@"
     ^--^ SC2124 (warning): Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.


In stack.sh line 36:
  "$ACTION" $ARGS
            ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

In stack.sh line 42:
  "$ACTION" $ARGS
            ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
---
 stack.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/stack.sh b/stack.sh
index 05c438a8..94ac5ae3 100755
--- a/stack.sh
+++ b/stack.sh
@@ -6,7 +6,7 @@ set -e
 
 ACTION="$1"
 shift
-ARGS="$@"
+ARGS=("$@")
 
 if [ "$ACTION" != "up" ] && [ "$ACTION" != "down" ]; then
     echo "Usage: $0 up|down [extra docker compose flags]"
@@ -25,7 +25,7 @@ cd /home/frappe/frappe_docker || {
 #   --env-file /home/frappe/gitops/traefik.env \
 #   -f overrides/compose.traefik.yaml \
 #   -f overrides/compose.traefik-ssl.yaml \
-#   "$ACTION" $ARGS
+#   "$ACTION" "${ARGS[@]}"
 
 # Uncomment this block when using mariadb container by frappe
 echo "==> MariaDB $ACTION $ARGS"
@@ -33,10 +33,10 @@ docker compose \
   --project-name mariadb \
   --env-file /home/frappe/gitops/mariadb.env \
   -f overrides/compose.mariadb-shared.yaml \
-  "$ACTION" $ARGS
+  "$ACTION" "${ARGS[@]}"
 
 echo "==> ERPNext $ACTION $ARGS"
 docker compose \
   --project-name erpnext-one \
   -f /home/frappe/gitops/erpnext-one.yaml \
-  "$ACTION" $ARGS
+  "$ACTION" "${ARGS[@]}"