From 20744238cb00f01a5948f6ca85cc456549663b96 Mon Sep 17 00:00:00 2001 From: Kevin Wakhisi Date: Sun, 11 Feb 2024 00:48:54 +0300 Subject: [PATCH] chore!i :alien: Enhance dev container YAML Enhance dev container YAML to meet standards and integrate personal GitHub environment token Refactored the existing dev container YAML configuration to adhere to best practices and coding standards. This includes optimizing container setup and dependencies for smoother development workflows. Additionally, integrated a personal GitHub environment token for secure authentication and access to GitHub resources within the container environment. This improvement enhances both security and usability, streamlining the development process. --- devcontainer-example/devcontainer.json | 44 ++++++++++++++++---------- 1 file changed, 28 insertions(+), 16 deletions(-) diff --git a/devcontainer-example/devcontainer.json b/devcontainer-example/devcontainer.json index d80b845d..76f60dab 100644 --- a/devcontainer-example/devcontainer.json +++ b/devcontainer-example/devcontainer.json @@ -1,25 +1,37 @@ { "name": "Frappe Bench", - "forwardPorts": [8000, 9000, 6787], + "forwardPorts": [ + 8000, + 9000, + 6787 + ], "remoteUser": "frappe", - "settings": { - "terminal.integrated.profiles.linux": { - "frappe bash": { - "path": "/bin/bash", - }, - }, - "terminal.integrated.defaultProfile.linux": "frappe bash", - "debug.node.autoAttach": "disabled", + "customizations": { + "vscode": { + "extensions": [ + "ms-python.python", + "ms-vscode.live-server", + "grapecity.gc-excelviewer", + "mtxr.sqltools", + "visualstudioexptteam.vscodeintellicode" + ], + "settings": { + "terminal.integrated.profiles.linux": { + "frappe bash": { + "path": "/bin/bash" + } + }, + "terminal.integrated.defaultProfile.linux": "frappe bash", + "debug.node.autoAttach": "disabled" + } + } }, "dockerComposeFile": "./docker-compose.yml", "service": "frappe", "workspaceFolder": "/workspace/development", "shutdownAction": "stopCompose", - "extensions": [ - "ms-python.python", - "ms-vscode.live-server", - "grapecity.gc-excelviewer", - "mtxr.sqltools", - "visualstudioexptteam.vscodeintellicode", - ], + "postStartCommand": "sudo service ssh start", + "mounts": [ + "source=${localEnv:HOME}${localEnv:USERPROFILE}/.ssh,target=/home/frappe/.ssh,type=bind,consistency=cached" + ] }