From 1f5a194ee94cb8a7698f32446017099d6f4a03f5 Mon Sep 17 00:00:00 2001
From: Lev Vereshchagin <mail@vrslev.com>
Date: Tue, 29 Mar 2022 12:16:12 +0300
Subject: [PATCH] Update custom app guide according to changes

---
 custom_app/README.md           | 4 +++-
 custom_app/backend.Dockerfile  | 6 ------
 custom_app/frontend.Dockerfile | 6 ------
 3 files changed, 3 insertions(+), 13 deletions(-)

diff --git a/custom_app/README.md b/custom_app/README.md
index 820ae7bc..d11b55bf 100644
--- a/custom_app/README.md
+++ b/custom_app/README.md
@@ -41,4 +41,6 @@ Cool! You just containerized your app!
 
 ## Installing multiple apps
 
-Both backend and frontend builds contain `install-app` script that places app where it should be. Each call to script installs given app. Usage: `install-app [APP_NAME] [BRANCH?] [GIT_URL?]`.
+Both backend and frontend builds contain `install-app` script that places app where it should be. Each call to script installs given app. Usage: `install-app [APP_NAME]`.
+
+If you want to install an app from git, clone it locally, COPY in Dockerfile.
diff --git a/custom_app/backend.Dockerfile b/custom_app/backend.Dockerfile
index cc779b1c..3bd32834 100644
--- a/custom_app/backend.Dockerfile
+++ b/custom_app/backend.Dockerfile
@@ -11,10 +11,4 @@ COPY . ../apps/${APP_NAME}
 RUN --mount=type=cache,target=/root/.cache/pip \
     install-app ${APP_NAME}
 
-# or with git:
-# ARG APP_NAME
-# ARG BRANCH
-# ARG GIT_URL
-# RUN install-assets ${APP_NAME} ${BRANCH} ${GIT_URL}
-
 USER frappe
diff --git a/custom_app/frontend.Dockerfile b/custom_app/frontend.Dockerfile
index 09424c17..205934c7 100644
--- a/custom_app/frontend.Dockerfile
+++ b/custom_app/frontend.Dockerfile
@@ -7,12 +7,6 @@ ARG APP_NAME
 COPY . apps/${APP_NAME}
 RUN install-app ${APP_NAME}
 
-# or with git:
-# ARG APP_NAME
-# ARG BRANCH
-# ARG GIT_URL
-# RUN install-app ${APP_NAME} ${BRANCH} ${GIT_URL}
-
 
 FROM frappe/erpnext-nginx:${ERPNEXT_VERSION}