epistemophiliac/fabric-samples
1
0
Fork 0
mirror of https://github.com/hyperledger/fabric-samples.git synced 2026-06-21 00:55:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Correct Javascript Chaincode (#445)

Browse source 
- In CreateAsset, await was never called on putState causing issues
especially with tools such as caliper and is not correct practice.
Unfortunately all the other examples use `return` which works but is
actually not the idiomatic way of handling promises, so here await is
chosen rather than return

Signed-off-by: D <d_kelsey@uk.ibm.com>

Co-authored-by: D <d_kelsey@uk.ibm.com>
This commit is contained in:
Dave Kelsey 2021-05-11 10:22:25 +01:00 committed by GitHub
parent 6ebf692ab8
commit 9f07960dae
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
asset-transfer-basic/chaincode-javascript/lib/assetTransfer.js
View file

@ -72,7 +72,7 @@ class AssetTransfer extends Contract {
Owner: owner, Owner: owner,
AppraisedValue: appraisedValue, AppraisedValue: appraisedValue,
}; };
ctx.stub.putState(id, Buffer.from(JSON.stringify(asset))); await ctx.stub.putState(id, Buffer.from(JSON.stringify(asset)));
return JSON.stringify(asset); return JSON.stringify(asset);
} }
@ -146,8 +146,6 @@ class AssetTransfer extends Contract {
} }
return JSON.stringify(allResults); return JSON.stringify(allResults);
} }
} }
module.exports = AssetTransfer; module.exports = AssetTransfer;