From 6cce07c4402614fe73c1451272da1fc82950c0f8 Mon Sep 17 00:00:00 2001 From: Yuki Kondo Date: Mon, 3 Jul 2017 13:55:26 -0700 Subject: [PATCH] [FAB-5155]Fix README.md in "balance-transfer" example The README in "balance-transfer" should be fixed in the section: https://github.com/hyperledger/fabric-samples/tree/master/ balance-transfer#running-the-sample-program 1. Broken link There is a link to "Sample REST APIs Requests" which is broken. This is linked to non-existent path on fabric-sdk-node repository. I believe the intended link is to https://github.com/hyperledger/fabric-samples/tree/master/ balance-transfer#sample-rest-apis-requests 2. Instruction to start node application. There is no instruction to start node application. If we execute the REST APIs according to the current README, we can't get any responses since node application is not working. We need to execute the following steps before calling REST APIs. - npm install - PORT=4000 node app fix repo names Change-Id: I9ec0ec18bb36addd6c8371481dc8cfe645053ec6 Signed-off-by: Yuki Kondo Signed-off-by: Christopher Ferris --- balance-transfer/README.md | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/balance-transfer/README.md b/balance-transfer/README.md index 6fcf23ab..53057065 100644 --- a/balance-transfer/README.md +++ b/balance-transfer/README.md @@ -11,7 +11,7 @@ A sample Node.js app to demonstrate **__fabric-client__** & **__fabric-ca-client * Download docker images ``` -cd fabric-sdk-node/examples/balance-transfer/ +cd fabric-samples/balance-transfer/ docker-compose -f artifacts/docker-compose.yaml pull ``` @@ -40,7 +40,21 @@ docker-compose -f artifacts/docker-compose.yaml up ``` ##### Terminal Window 2 -* Execute the REST APIs from the section [Sample REST APIs Requests](https://github.com/hyperledger/fabric-sdk-node/tree/master/examples/balance-transfer#running-the-sample-program) +* Install the fabric-client and fabric-ca-client node modules + +``` +npm install +``` + +* Start the node app on PORT 4000 + +``` +PORT=4000 node app +``` + +##### Terminal Window 3 + +* Execute the REST APIs from the section [Sample REST APIs Requests](https://github.com/hyperledger/fabric-samples/tree/master/balance-transfer#sample-rest-apis-requests) ### Option 2: @@ -48,7 +62,7 @@ docker-compose -f artifacts/docker-compose.yaml up ##### Terminal Window 1 ``` -cd fabric-sdk-node/examples/balance-transfer +cd fabric-samples/balance-transfer ./runApp.sh @@ -67,7 +81,7 @@ instructions [https://stedolan.github.io/jq/](https://stedolan.github.io/jq/) With the application started in terminal 1, next, test the APIs by executing the script - **testAPIs.sh**: ``` -cd fabric-sdk-node/examples/balance-transfer +cd fabric-samples/balance-transfer ./testAPIs.sh